From 94231ffd98496cbcb1c15b7bf2a9edfd5f852cd4 Mon Sep 17 00:00:00 2001
From: brandon-height <33162344+brandon-height@users.noreply.github.com>
Date: Tue, 3 Apr 2018 11:23:30 -0700
Subject: [PATCH] Fix table-driven example documentation (#363)

Prior to this change, the example documentation
found in the README.md has an errant code which
won't work in the table-driven code example.

This change modifies the variable name from `t` to `tc`
so it does not conflict with the `t *testing.T` struct
definition.

* Adds a range clause to the `for` statement
* Modifies `for` statement scope to use `tc.shouldPass`, and `tc.routeVariable`

Doc: https://github.com/gorilla/mux#testing-handlers
---
 README.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/README.md b/README.md
index ad24249..8f55ddc 100644
--- a/README.md
+++ b/README.md
@@ -593,8 +593,8 @@ func TestMetricsHandler(t *testing.T) {
         {"adhadaeqm3k", false},
     }
 
-    for _, t := tt {
-        path := fmt.Sprintf("/metrics/%s", t.routeVariable)
+    for _, tc := range tt {
+        path := fmt.Sprintf("/metrics/%s", tc.routeVariable)
         req, err := http.NewRequest("GET", path, nil)
         if err != nil {
             t.Fatal(err)
@@ -606,9 +606,9 @@ func TestMetricsHandler(t *testing.T) {
 
         // In this case, our MetricsHandler returns a non-200 response
         // for a route variable it doesn't know about.
-        if rr.Code == http.StatusOK && !t.shouldPass {
+        if rr.Code == http.StatusOK && !tc.shouldPass {
             t.Errorf("handler should have failed on routeVariable %s: got %v want %v",
-                t.routeVariable, rr.Code, http.StatusOK)
+                tc.routeVariable, rr.Code, http.StatusOK)
         }
     }
 }